Aias00 commented on PR #4356: URL: https://github.com/apache/rocketmq-dashboard/pull/4356#issuecomment-5695504469
Addressed the lifecycle review points on the rebased branch (`be544af5`): - Broker restart is now a real UI caller with confirmation and typed dispatch feedback; focused ClusterPage tests cover it. - Studio's write authorization is implemented by the globally registered `AuthInterceptor`, rather than `@PreAuthorize`. With login protection enabled, readers now have explicit regression coverage showing 403 for every Broker/NameServer/Proxy lifecycle POST route. The docs also clarify that `login-required=false` intentionally has no admin boundary. - `targetVersion` is normalized and validated in `ClusterService`, then guarded again in `ProcessLifecycleOperationExecutor` before the process runner. Leading-option, whitespace/control-containing, and oversized values cannot enter `argv`. The NameServer tab remains registry CRUD by design: a registry entry is an address directory record, not deployment inventory. I did not make its create/edit/delete buttons claim process provisioning. NameServer lifecycle remains a separate API/service contract for deployment integrations and a future discovered-node workflow. The branch was rebased onto current `rocketmq-studio` (`e5ac52440`). Verification: 2445 backend tests, 1042 frontend tests, Checkstyle 0, build passed, lint 0 errors, and independent review found no remaining issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
