lizhimins commented on PR #4312: URL: https://github.com/apache/rocketmq-dashboard/pull/4312#issuecomment-5694514624
Closing as superseded by your own #4356, which reworks the same `cluster/lifecycle/` package and touches the same 19 production files plus `UpdateNameServerDTO`. Let's continue on #4356. The questions we raised on this one still apply there and need answering before it can be merged: only `PROXY_RESTART` has a UI caller (the broker button still renders `restartNotSupported`); the project has no RBAC at all (no `@PreAuthorize` / `hasRole` anywhere), so the documented "administrators only" cannot be enforced; and `targetVersion` is free text that reaches `argv` unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
