lizhimins commented on PR #4186: URL: https://github.com/apache/rocketmq-dashboard/pull/4186#issuecomment-5694491905
Closing because the patch no longer applies: both files it targets were removed by #4225, when the tool layer moved to `ops/ai/tool/handler/` with the catalog in `tool-catalog/tools/*.yaml`. The gap you found is still live, so this is worth resubmitting against the new location: `tools/alert.yaml:31-37` declares `metric` as required with `minLength: 1`, `AlertRuleListItem` passes it through with NON_NULL, and `ToolValidationFilter` validates tool output at runtime and throws — while `AlertService` only validates the rule name on create. One rule without a metric therefore fails the entire `rmq.alert.rule.list` response. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
