lizhimins commented on PR #4226: URL: https://github.com/apache/rocketmq-dashboard/pull/4226#issuecomment-5694502478
Closing. The change pins `abbreviate`, but `hasOversizedProperty` in the same class still counts UTF-16 chars, so an oversized property value falls back to `value.length()` and can still be cut inside a surrogate pair; the javadoc also still documents a character cap. For context: #4170 covered both methods plus the javadoc and added a 1024-code-point boundary case, and its author closed it in favour of this PR. We are not taking either variant right now — a resubmission needs to cover `abbreviate`, `hasOversizedProperty` and the javadoc in one change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
