lizhimins commented on PR #4195:
URL: 
https://github.com/apache/rocketmq-dashboard/pull/4195#issuecomment-5694497250

   Closing as part of clearing the metric-profile queue, not because the 
finding is wrong.
   
   The mismatch you point at is real: four `mapping(...)` entries advertise 
`topic` / `message_type` while their PromQL aggregates `by (cluster, node_id)`, 
so the profile claims labels the query never groups by. We are folding that 
into trunk-side work that gives the advertised labels a single source of truth 
together with the `scopeLabels` table added by #3989, rather than keeping a 
second hard-coded list per profile. Thanks for the analysis — it is what made 
us schedule that.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to