btlqql commented on PR #4290:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4290#issuecomment-5682855860
Reopened and rebased as requested.
The rebase moved the branch from `6c24d2ed` to the current `rocketmq-studio`
head (`1e8cc591`). Two
adjustments were needed because upstream refactored `findPage` since this
branch was written:
- `findPage` now delegates to `applyFilters(...)` (which also gained the
`target` / `clusterIdMissing`
parameters). The escaping therefore lives in `applyFilters`, so **every**
caller - `findPage` and
all five aggregate queries of `summarize` - gets the escaped pattern from
one place. The conflict was
resolved in favour of upstream's structure.
- The new tests call `findPage` with the current 11-argument signature.
Fresh evidence on the rebased head (`cf801d70`):
Red, `upstream/rocketmq-studio` version of `MybatisPlusAuditRepository.java`
with the branch tests:
```
[ERROR] Tests run: 14, Failures: 2, Errors: 0, Skipped: 0, Time elapsed:
2.108 s <<< FAILURE! -- in
org.apache.rocketmq.studio.ops.audit.MybatisPlusAuditRepositoryTest
to contain only:
to contain only:
```
Green, with the fix (`mvn -f server/pom.xml test
-Dtest=MybatisPlusAuditRepositoryTest`):
```
[INFO] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
2.055 s -- in
org.apache.rocketmq.studio.ops.audit.MybatisPlusAuditRepositoryTest
[INFO] BUILD SUCCESS
```
The two failures are the escaping tests (`%100\%\_done%` / `%a\_b\%%`); they
still discriminate the
behaviour on the current base. `mergeable_state` is `clean` again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
