Aias00 opened a new pull request, #4345:
URL: https://github.com/apache/rocketmq-dashboard/pull/4345
## Summary
Reimplements #4148 as a separate PR from the latest `rocketmq-studio`
baseline, following the maintainer review without rewriting the original PR
history.
- add nested `page: {page, pageSize}` using the existing typed `PageRequest`
contract to both `rmq.message.query` and `rmq.message.query_by_topic`; default
to 1/20 and cap tool requests at 100 in the catalog schema
- reuse `MessageService.queryMessagesPage(...)` for message-ID,
business-key, and Topic queries; preserve the direct unique-key lookup and wrap
its 0..1 result in the same paging contract
- serialize the established common `PageOutput` fields as `{page, pageSize,
total, items}`, with `resultMayBeTruncated` as message-specific metadata
- add `includeBody` to both query tools, default false; omit `body`,
`bodyEncoding`, and `bodyTruncated` unless explicitly requested
- preserve identifier priority `msgId`, then `uniqueKey`, then `key`
- add optional `traceTopicName`; non-blank values use the existing
four-argument trace service while blank/absent values keep the legacy
three-argument path
- keep the existing tool count, L1 permissions, REST/service APIs, and
provider implementations unchanged
## Verification
- TDD red: the rewritten contract tests initially failed because
`MessageQueryOutput`, nested paging, and `traceTopicName` did not exist
- focused handler/catalog/output contract tests: 25 passed
- MessageService, REST controller, MCP registration/discovery/invocation,
message handlers, catalog, and output-schema tests: 73 passed
- full server suite with `-Dspring.profiles.active=dev`: 260 test classes,
2361 tests, 0 failures/errors/skips
- `mvn -B -ntp -DskipTests package`: passed, Checkstyle 0 violations
- `git diff --check`: passed
- independent read-only review: no findings
Supersedes #4148
Closes #4143
Closes #4147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
