RockteMQ-AI commented on code in PR #4331:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4331#discussion_r4016227275
##########
web/src/pages/cluster/index.tsx:
##########
@@ -116,6 +116,34 @@ const CONFIG_FIELD_LABEL_KEYS: Record<string, string> = {
msgTraceTopicName: 'cluster.msgTraceTopicName',
};
+type RequestGeneration = {
+ begin: () => number;
+ isCurrent: (requestId: number) => boolean;
+ invalidate: () => void;
+};
+
+const createRequestGeneration = (): RequestGeneration => {
Review Comment:
**[Info]** The `createRequestGeneration` helper is a clean abstraction. One
minor consideration: the `invalidate()` method increments the counter, which
means after invalidation, `isCurrent()` will return false for any in-flight
requests. This is correct behavior, but worth noting that `invalidate()` and
`begin()` have the same effect on the counter — both increment it. If the
intent is to distinguish between "start a new request" and "cancel existing
requests", you might consider making the semantics more explicit in the type
signature or comments.
That said, the current implementation is correct and the test coverage
(especially the stale-response test) validates the behavior well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
