lizhimins commented on PR #4214:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4214#issuecomment-5679325927
Closing as covered by #4177, which is now merged into `rocketmq-studio` as
`da6d98a5e`.
Mainline landed `disabled={editingInstance?.vendor != null &&
editingInstance.vendor !== 'APACHE'}`, which is strictly broader than the
`vendor === 'ALIYUN' || vendor === 'TENCENT'` check here — it also covers any
future non-APACHE vendor instead of needing the list extended. #4177 was opened
a day earlier and ships the matching `InstancePage.test.tsx` case (`keeps the
endpoint editable for Apache instances but read-only for cloud vendors`), so
the behaviour is pinned as well.
Thanks for filing #4176 and for the fix — the diagnosis was right, and it is
now in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
