RockteMQ-AI commented on issue #11166: URL: https://github.com/apache/rocketmq/issues/11166#issuecomment-5678323578
**Issue Evaluation** Category: `bug` | Status: **Confirmed** The reported issue has been verified against the current codebase. **Root Cause:** `TieredStoreMetricsManager.initMetrics()` catches `ConsumeQueueException` in two metric collection callbacks (lines 202 and 241) but silently ignores them with only a `// TODO: handle exception` comment. When collection fails, no measurement is recorded and no error is logged. **Comparison:** `PopMetricsManager` handles the same exception type correctly by logging with `log.error(message, e)`, keeping callbacks non-disruptive while making failures observable. **Impact:** Operators cannot distinguish a zero metric value from an unsuccessful collection attempt in `dispatchBehind` and `dispatchLatency` gauges. **Severity:** medium — affects observability, not message processing functionality. **Proposed Fix:** Add error logging in both catch blocks, following the pattern used in `PopMetricsManager`. An automated fix proposal will be generated. Reply with `/approve` to proceed with PR generation. --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
