btlqql commented on PR #4288:
URL: 
https://github.com/apache/rocketmq-dashboard/pull/4288#issuecomment-5667248569

   Withdrawing this one: it duplicates #4226 (issue #4167), which was opened 
earlier and is already
   CLEAN with the AI review approved, so this branch would only race it.
   
   Both branches cut an oversized property value on a code point boundary. The 
only substantive
   difference is the cap semantics: #4226 makes `MAX_PROPERTY_VALUE_CHARS` 
count code points for both
   `abbreviate` and `hasOversizedProperty`, while this branch keeps the cap in 
UTF-16 chars and only
   steps back one char when the cut would split a pair. The former is the 
better reading of the
   constant's name, so #4226 should land.
   
   Closing #4287 as a duplicate of #4167 for the same reason. Nothing in this 
branch is merged
   elsewhere; it carries a passing red/green pair (`audit/rmq-pt-red.log`, 
`audit/rmq-pt-green.log`)
   should it ever be needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to