unbridled-41 commented on PR #4285: URL: https://github.com/apache/rocketmq-dashboard/pull/4285#issuecomment-5657468922
## 复测实证(应用户要求对缺陷做最终实测) 在干净 worktree(pristine 6c24d2ed)上重新做了两层验证: **① 基线复现(只带本 PR 回归测试 + 基线源码)**: ``` npx vitest run src/pages/ops/__tests__/SystemAlertsPage.test.tsx × surfaces the label validation message when the silence labels are invalid Tests 2 failed | 22 passed (24) ← 同批含 #4283 用例,另一失败为其同款 ``` (断言期望出现专用校验消息「标签格式应为 key=value,并以逗号分隔」,实际只有通用 toast——与 Issue 描述一致。) **② 修复解除(仅替换 systemAlerts.tsx 为修复版)**: ``` Test Files 2 passed (2) / Tests 24 passed (24) ``` **③ 无兜底主张核实**:`createAlertSilence`(HTTP 调用)仅在请求构造成功后才被调用——校验异常抛出点(parseSilenceLabels / zonedLocalDateTimeToUtc)先于任何请求,axios 拦截器无从展示;回归测试同时断言 `createAlertSilence` 未被调用。失败确为"零指向的死路"。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
