unbridled-41 commented on PR #4257:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4257#issuecomment-5648112255
## Verification evidence
- **CI**: branch head `4f78b5ab4aa89f50654515a9c34e89c2ebb2f0e9` (PR #4257)
has exactly one workflow run for this head: "CI" (pull_request event), run
34713709732, conclusion=startup_failure — the upstream workflow fails at
startup for every branch in this repository, producing no check-runs
(`check-runs total_count = 0`). Unrelated to this change; all local
verification below was run on this head.
- **Red light (unfixed code)**: with only the new tests applied to the
baseline sources, `mvn -o test -Dtest='ToolCatalogTest,ToolGatewayServiceTest'
-DfailIfNoTests=false` → `Tests run: 43, Failures: 1, Errors: 2`:
- `ToolCatalogTest.messageToolInputsAreInstanceAddressed` — failed
(canonical catalog still requires `cluster`);
-
`ToolGatewayServiceTest.messageQueryToolTargetsTheInstanceNamedByItsInput` /
`messageTraceToolTargetsTheInstanceNamedByItsInput` — errored with
`BusinessException: Tool input validation failed for rmq.message.query: [:
required property 'cluster' not found, : property 'instance' is not defined in
the schema and the schema does not allow additional properties]`.
- **Module tests (fixed)**: `ToolCatalogTest` 7/7, `ToolGatewayServiceTest`
36/36 (incl. the reader-permission test re-keyed to `instance`),
`MessageQueryToolHandlerTest` 6/6, `MessageTraceToolHandlerTest` 1/1 — `Tests
run: 50, Failures: 0` (re-run after the final commit, post lint-staged).
- **Full server suite + baseline**: `mvn -o test` on this head → `Tests run:
2154, Failures: 2` = the standing baseline failure set
(`AuthCorsIntegrationTest.shouldStillRejectAnonymousProtectedRequests` +
`shouldRejectNonAdminMutationBeforeControllerExecution`, 403-vs-401), i.e. 2151
baseline + 3 new tests with zero new failures.
- **Web**: new `AiPage` test pins the template contract (`{"instance": ""}`,
never the selected cluster id) — `AiPage.test.tsx` 18/18. Full `npx vitest
run`: 120 files, `Tests 3 failed | 979 passed (982)`; all three failures are
untouched files and known load-fragile cases under the parallel suite
(`ClusterPage.test.tsx` ×1, `ConsumerPage.test.tsx` ×2); both files re-run in
isolation → `Tests 56 passed (56)`.
- **Build**: `npx tsc -b` clean; `npx eslint .` 0 errors (10 warnings, all
in untouched files); `npx vite build` succeeds. Server checkstyle runs as part
of the Maven validate phase and passed (an earlier intermediate edit was
corrected for it).
- **Diff self-check** (`git show --numstat`): MessageQueryToolHandler +1/−1,
MessageTraceToolHandler +1/−1, ToolCatalog +5/−1, ToolGatewayService +10/−3,
rmq-tools.yaml +6/−4, MessageQueryToolHandlerTest +6/−6,
MessageTraceToolHandlerTest +1/−1, ToolCatalogTest +16/−0,
ToolGatewayServiceTest +26/−1, AiPage.test.tsx +26/−0 — 10 files, +98/−18, no
unrelated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
