unbridled-41 commented on PR #4254: URL: https://github.com/apache/rocketmq-dashboard/pull/4254#issuecomment-5647667001
## Verification evidence - **CI**: branch head `33771da6d04cc15a1cd450bb6c9ce71a0427bea5` (PR #4254) has exactly one workflow run for this head: "CI" (pull_request event), run 34709664270, conclusion=startup_failure — the upstream workflow fails at startup for every branch in this repository, producing no check-runs (`check-runs total_count = 0`). Unrelated to this change; all local verification below was run on this head. - **Red light (unfixed code)**: with the regression test kept and the baseline `systemAlerts.tsx` restored, `npx vitest run src/pages/ops/__tests__/SystemAlertsPage.test.tsx` → `Tests 1 failed | 14 passed (15)`, failing item `× resets the silence form after the dialog is dismissed without creating` (rule ID / label scope survived cancel+reopen). - **Module tests (fixed)**: `npx vitest run src/pages/ops/__tests__/SystemAlertsPage.test.tsx` → `Tests 15 passed (15)`. - **Full suite + baseline**: `npx vitest run` on this head → 120 files, `Tests 1 failed | 981 passed (982)`; the single failure is `ConsumerPage.test.tsx`, untouched by this branch and a recurring load-fragile case; re-run in isolation → `Tests 31 passed (31)`. Zero failures in files touched by this change. - **Build**: `npx tsc -b` clean; `npx vite build` succeeds. `npx eslint .` → 0 errors; the `systemAlerts.tsx` warning (line 227, react-hooks/exhaustive-deps) is pre-existing and outside this change's hunks. - **Diff self-check** (`git show --numstat`): `web/src/pages/ops/systemAlerts.tsx +4/−1`, `web/src/pages/ops/__tests__/SystemAlertsPage.test.tsx +43/−0` — no unrelated changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
