unbridled-41 commented on PR #4241:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4241#issuecomment-5637956990
## Verification evidence
**CI**: This PR's head SHA `efafdda638cb2bd335eccb2eff2b574dd6633490` has
exactly one workflow run — "CI" (pull_request), run id 34625762915, conclusion
`startup_failure`; check-runs API returns 0. The upstream workflow has been
failing at startup for all PRs in this repository (including every recently
merged one), so no CI signal is available; all verification below was run
locally.
**Red-light actual output** (before the fix, both new tests):
```
FAIL src/pages/instance/__tests__/InstancePage.test.tsx > ... > surfaces the
server error reason when creating an instance fails
❯ src/pages/instance/__tests__/InstancePage.test.tsx:419:20 (update case)
expect(await screen.findByText('Instance endpoint is not
reachable')).toBeInTheDocument();
Tests 2 failed | 23 skipped (25)
```
Both assertions on the server-provided message timed out because only the
generic "添加实例失败/更新实例失败，请稍后重试" toast rendered.
**Module tests**: after the fix, `npx vitest run
src/pages/instance/__tests__/InstancePage.test.tsx` → `Tests 25 passed (25)`
(23 pre-existing + 2 new).
**Full suite + baseline**: `npx vitest run` on this branch → `Tests 1 failed
| 982 passed (983)` (981 pre-existing + 2 new). The single failure is
MetricsExplorer — a file this PR does not touch; re-run in isolation it passes
`Tests 25 passed (25)`, matching the parallel-load flakiness recorded for that
file in previous rounds' baselines. Zero new failures.
**Build**: `npm run build` → exit 0; `npx tsc --noEmit` clean; `npx eslint`
on both changed files clean.
**Diff self-check**: `git show --numstat HEAD` → `45 0
web/src/pages/instance/__tests__/InstancePage.test.tsx` and `2 2
web/src/pages/instance/index.tsx`; 2 files, +47/−2, no unrelated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
