unbridled-41 commented on PR #4240:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4240#issuecomment-5637954275
## Verification evidence
**CI**: This PR's head SHA `64df3418c9a43c38c4d7190cc95d63140a43b831` has
exactly one workflow run — "CI" (pull_request), run id 34625707099, conclusion
`startup_failure`; check-runs API returns 0. The upstream workflow has been
failing at startup for all PRs in this repository (including every recently
merged one), so no CI signal is available; all verification below was run
locally.
**Red-light actual output** (before the fix, `npx vitest run
src/pages/cluster/__tests__/ClientsPage.test.tsx -t "clears column filters when
the nameserver changes"`):
```
❯ src/pages/cluster/__tests__/ClientsPage.test.tsx:521:25
expect(await screen.findByText('[email protected]:49155')).t…
| ^
Test Files 1 failed (1)
Tests 1 failed | 19 skipped (20)
```
The row for the new endpoint's Producer connection never rendered because
the stale Consumer column filter from the previous endpoint still applied.
**Module tests**: after the fix, `npx vitest run
src/pages/cluster/__tests__/ClientsPage.test.tsx` → `Tests 20 passed (20)` (19
pre-existing + 1 new), including the pre-existing `applies table column filters
to the exported CSV` and both stale-response guard tests, which pin the
behavior this change must not break.
**Full suite + baseline**: `npx vitest run` on this branch → `Test Files 3
failed | 117 passed (120)`, `Tests 4 failed | 978 passed (982)`. The 4 failures
are MetricsExplorer (1), ClusterPage (1), ConsumerPage (2) — none of these
files is touched by this PR (numstat below). Re-running the three failed files
in isolation: `Tests 81 passed (81)`, confirming they are the parallel-load
flakiness recorded for these exact files in previous rounds' baselines, not
regressions introduced here.
**Build**: `npm run build` → exit 0 (`✓ built in 10.59s`); `npx tsc
--noEmit` clean; `npx eslint` on both changed files clean. (One intermediate
build failure during development was in the new test's own mock typing and was
fixed before commit; the committed tree builds.)
**Diff self-check**: `git show --numstat HEAD` → `57 0
web/src/pages/cluster/__tests__/ClientsPage.test.tsx` and `7 0
web/src/pages/cluster/clients.tsx`; 2 files, +64/−0, no unrelated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
