zjncs commented on PR #3995: URL: https://github.com/apache/rocketmq-dashboard/pull/3995#issuecomment-5634446596
Thanks for the careful review — agreed on all four points: without a backfill the cutover splits the table across two time bases, `gmt_create`/`gmt_modified` would keep drifting with the MySQL session zone, the day-granularity filter inherits the same offset problem, and the export header gave the consumer no way to know the zone. I've rescoped this PR to the smaller first step you offered: **no change to the stored base** (writes, UI rendering and the cleanup cutoff all stay on the server-local base they use today), and the exported CSV's timestamp column is now named after the server's UTC offset — `timestamp(UTC+08:00)` on the documented `TZ=Asia/Shanghai` deployment, `timestamp(UTC)` on a UTC server — computed from the JVM default zone at export time. `AuditServiceTest#exportLogsLabelsTimestampColumnWithServerZoneOffset` pins both zones (fail-before on the base branch: the header exports as bare `timestamp,`), full class 15/15 green. Branch rewritten onto the current `rocketmq-studio` as a single commit. The repo-wide unification — one persisted time base, schema defaults, backfill for existing rows, and display/CSV labeling together — is exactly the dedicated effort you described; I'll prepare it as its own change once this lands or alongside it, whichever you prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
