lizhimins commented on PR #10826: URL: https://github.com/apache/rocketmq/pull/10826#issuecomment-5614297666
Rebased onto the latest `develop` and squashed into a single commit (`0a2a49794d`). What this commit changes: - **Admin RPC correctness rewrite** (`ProxyAdminGrpcService`, `AdminModelConverter`): the 16 RPCs now honour the upstream contract — broker calls go through an async gateway fanned out to all relevant brokers concurrently with a per-hop deadline; fields the open-source proxy cannot supply are left unset / answered with an explicit status instead of faked. - **Cross-proxy forwarding + client relay**: new `ProxyAdminForwarder` and `ProxyRelayRequest`; `ClusterProxyRelayService` / `GrpcClientChannel` / `GrpcChannelManager` wire up relaying telemetry commands to the owning client and forwarding when the client is attached to a peer proxy. - **Gateway capability**: `AdminService` / `DefaultAdminService` turned fully async, adding `getBrokerClusterInfo`, `queryConsumeTimeSpan`, `getConsumerConnectionList`, UNIQ_KEY `queryMessage` (with `decompressBody`), etc. - **Cluster-visible connections/subscriptions**: broker-side `ConsumerConnection` merged with the proxy's `ConsumerManager`, deduplicated by group + topic. - **Two P0 fixes**: `AdminSendMessage` no longer throws on timer/FIFO system properties; `VerifyMessage` no longer overflows when relaying large/compressed messages; an unresponsive broker no longer hangs the RPC. - **Auth hardening** (`ProxyAdminAuthInterceptor`): fail-closed mode now requires both cluster authentication and authorization to be enabled, refusing otherwise (`UNAUTHENTICATED` / `FAILED_PRECONDITION`) so the `proxy.admin.*` ACL is truly enforced. - **Config / wiring + slimming**: admin config keys unified as `grpcAdminServer*` plus `grpcAdminServerRequestTimeoutMillis`; removed `ProxyAdminMetricsInterceptor` / `ProxyAdminMetricsManager` and their tests. - **proto build**: `rocketmq-proto` generated from the `rocketmq-apis` submodule + skips Maven deploy. - **Docs**: rewrote `docs/proxy-admin.md` + `docs/proxy-admin-zh.md`; removed the old `rip-2-*` docs. - **Tests**: reworked and trimmed the four admin test classes, added `GrpcClientChannelTest`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
