89799969 opened a new pull request, #4202:
URL: https://github.com/apache/rocketmq-dashboard/pull/4202
## What is the purpose of the change
Fixes #4201.
After #4049, both full and paged data-source inventories are cached.
InstanceService.deleteInstance updates DataSourceVO.instanceIds through
SettingsRepository directly, bypassing the cache-eviction annotations in
SettingsService. A successful deletion can therefore leave both cached
inventories exposing the old instance binding.
This change invalidates the shared data-source cache only after the
instance-deletion transaction commits. A rollback keeps the existing cache
intact, and callers without active transaction synchronization retain the
previous immediate-cleanup behavior.
## Brief changelog
- centralize the shared data-source cache name
- clear that cache after a successful instance-deletion commit
- keep endpoint/client cleanup on the same post-commit boundary
- add regression coverage for binding removal, cache eviction, and commit
timing
## Verifying this change
- Focused tests: InstanceServiceTest and SettingsServiceCachingTest
- 84 tests run, 0 failures, 0 errors, 0 skipped
- Checkstyle: 0 violations
- The full server suite was also attempted, but this Windows host reported
unrelated Java loopback-socket failures in HTTP/client tests plus two AuthCors
assertions; no full-suite pass is claimed, and CI can provide clean-host
coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
