lizhimins commented on PR #4126:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4126#issuecomment-5602181565
Closed as folded into #4119, merged into `rocketmq-studio` as f04dea2b.
Your change shipped as-is:
`AlertRuleSemanticFingerprint.normalizedThreshold` now goes through the class's
own `normalize()`, and `AlertNotificationTemplate.formattedValue` trims before
consulting `RATIO_METRICS` (and gained a null guard). Both user-visible
consequences you described check out — a rule stored as `"
broker.disk.usage_ratio "` kept its raw ratio threshold so `0.9 >= 85` could
never fire, and its notification rendered `${value}` as `0.865%` instead of
`86.5%`. Your worked examples matched the code exactly.
Two follow-ups recorded rather than done here: `RATIO_METRICS` exists as two
verbatim copies across those classes and should be pulled down into
`common/util`, and the codebase mixes `trimWhitespace` with `trim()` for the
same normalisation. See the note on #4124 about normalising once at the read
boundary instead, which would subsume both.
For context on the grouping: these four all sit on the native alert
evaluation path and each one alone leaves the others still misfiring, so they
were integrated as one change on the target PR's branch, each kept as its own
commit with you as the author.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
