lizhimins commented on PR #4117: URL: https://github.com/apache/rocketmq-dashboard/pull/4117#issuecomment-5602086573
Closed as folded into #4115, merged into `rocketmq-studio` as 206314b9. Your change shipped as-is: `cluster.proxies`, `stats.totalProxies`, `stats.totalNameServers` and `items[].totalLag` in `tool-catalog/rmq-tools.yaml` are now `type: [integer, 'null']` while staying `required`, and your `ToolGatewayServiceTest` cases came across with it. Your diagnosis was the useful part — `ToolGatewayService.validateOutput` keeps null keys through `valueToTree`, so a producer that deliberately emits null for "unknown" failed schema validation and surfaced as a 500 rather than as a missing value. Auditing the rest of the integer output fields confirmed these four are the complete reachable set. One thing worth knowing: on its own this would not have changed any observable behaviour, because both handlers were still passing the `cluster` input into the `instanceId` slot and therefore threw `404 Instance not found` before output validation was ever reached. That is why it landed together with the routing fix rather than separately. Nothing further needed from you — thank you for the fix. For context on why these were grouped: the AI resource tool chain had four independent defects (argument-slot routing, output-schema nullability, cloud topic type/perm, cloud consumer-group subscription mode) and merging any single one of them would not have made `rmq.topic.list` or `rmq.group.list` usable, so they were integrated as one change on the target PR's branch, each kept as its own commit with you as the author. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
