lizhimins commented on PR #4134: URL: https://github.com/apache/rocketmq-dashboard/pull/4134#issuecomment-5602087404
Closed as folded into #4115, merged into `rocketmq-studio` as 206314b9. Your change shipped as-is: both cloud providers now set `SubscriptionMode.Push`, and Aliyun's `toConsumeType` returns `CLUSTERING` instead of null when `messageModel` is absent or not Broadcasting, so `requiredEnumName` no longer throws for every cloud consumer group. Your reasoning for hardcoding Push held up — the pinned `alibabacloud-rocketmq20220801` response body carries no subscription-mode field at all, and it matches what the Apache provider already asserts for its own groups. This one had to be integrated rather than merged in sequence: it and #4137 both add an import to `AliyunConverters.java` and both extend `AliyunInstanceProviderTest` / `TencentInstanceProviderTest`, so whichever landed second needed a rebase. Putting both on one branch resolved that once, and both sets of tests pass together (44 Tencent, 29 Aliyun). Nothing further needed from you — thank you for the fix. For context on why these were grouped: the AI resource tool chain had four independent defects (argument-slot routing, output-schema nullability, cloud topic type/perm, cloud consumer-group subscription mode) and merging any single one of them would not have made `rmq.topic.list` or `rmq.group.list` usable, so they were integrated as one change on the target PR's branch, each kept as its own commit with you as the author. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
