unbridled-41 commented on PR #4169:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4169#issuecomment-5587085786
## Verification evidence
- **CI**: for this PR's head SHA `29c0f4f0` (verified before commenting):
`gh api /repos/apache/rocketmq-dashboard/actions/runs?head_sha=<sha>` returns
exactly one `CI (pull_request)` run with `conclusion=startup_failure`, and
`/commits/<sha>/check-runs` reports `total_count=0`. The upstream workflow
never starts for any branch here (recent base-branch runs are also
startup_failure), so nothing can pass or fail CI.
- **Red** (base `0a596661`, only the two new tests added; fix stashed): `npx
vitest run src/pages/studio/__tests__/Producer.test.tsx` → `Tests 2 failed | 13
passed (15)`:
- `clears stale connection results when the topic changes`:
`expect(element).not.toBeInTheDocument() ... found <td
class="ant-table-cell">producer-1</td>` — the previous topic's client row
survived the topic switch.
- `exports connections with the form topic after switching topics`: the
export button remained enabled with the stale rows cached (a click would export
topic A's clients labelled as topic B).
- **Module tests** after the fix: `npx vitest run
src/pages/studio/__tests__/Producer.test.tsx` → `Test Files 1 passed (1)`,
`Tests 15 passed (15)` (13 pre-existing + 2 new).
- **Full suite + baseline comparison** after the fix: `npx vitest run` →
`Test Files 3 failed | 112 passed (115)`, `Tests 3 failed | 943 passed (946)`.
Failing files: `ClusterPage` ×1, `ConsumerPage` ×1,
`NotificationDeliveriesPage` ×1 — none is touched by this change. Running those
three files in isolation with the fix applied → `Test Files 3 passed (3)`,
`Tests 59 passed (59)`, matching the documented load-flakiness of these files
under full-suite parallelism.
- **Build**: `npm run build` → `✓ built in 11.08s`;
`node_modules/.bin/eslint` on both changed files clean (one unused-var warning
in the new test itself was fixed before commit); `tsc --noEmit` clean. These
cover the CI web build/lint steps, which cannot run due to the startup_failure
above.
- **Diff self-check**: `git show 29c0f4f0 --numstat` → `2 files changed, 80
insertions(+)`: `web/src/pages/studio/Producer.tsx` +2/−0 (the two
`setConnectionList([])`/`setConnectionSummary(null)` lines in
`handleTopicChange`), `web/src/pages/studio/__tests__/Producer.test.tsx` +78/−0
(two new regressions). No unrelated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
