liooooo29 commented on PR #1360: URL: https://github.com/apache/rocketmq-clients/pull/1360#issuecomment-5580872518
Update for reviewers on the latest commit (`d4ed6be7`): - **Dropped `LiteSimpleConsumerTrait`.** Following the crate's existing pattern (`SimpleConsumer`/`Producer`/`PushConsumer` expose inherent methods only) and Rust API best practice (no trait when there is no `dyn`/generic usage), all methods are now inherent on `LiteSimpleConsumer`. This also removes the `async_trait` per-call boxing overhead. - **Adopted the review suggestion on lifecycle fields.** `shutdown_token`/`task_tracker` now hold `CancellationToken::default()` / `TaskTracker::default()` directly instead of `Option<>` (both implement `Default` in tokio-util 0.7), which simplifies `shutdown()`. `cargo fmt`/clippy clean; `cargo test --lib` 88 passed (1 pre-existing unrelated `session_new` failure); `cargo test --test lite_integration_test` 4 passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
