unbridled-41 commented on PR #4166: URL: https://github.com/apache/rocketmq-dashboard/pull/4166#issuecomment-5586530319
## Verification evidence - **CI**: for this PR's head SHA `fb3cbcf58c9f88c9c9b15590957ba2ff82bea7d4`, `gh api /repos/apache/rocketmq-dashboard/actions/runs?head_sha=<sha>` returns exactly one run: `CI (pull_request)` with `conclusion=startup_failure`, and `/commits/<sha>/check-runs` reports `total_count=0` — the upstream workflow never starts (same for recent base-branch runs), so nothing here can pass or fail CI. - **Red** (base `0a596661`, only the new test added): `npx vitest run src/pages/cluster/__tests__/ClusterPage.test.tsx -t "discards a superseded broker config preview response"` → `Tests 1 failed | 25 skipped`. Failure: `TestingLibraryElementError: Unable to find an element with the text: defaultTopicQueueNums=24` — after the stale first preview resolved last, the panel contained the stale `defaultTopicQueueNums=16` tag instead of the latest `defaultTopicQueueNums=24` (the exact defect). - **Module tests** after the fix: `npx vitest run src/pages/cluster/__tests__/ClusterPage.test.tsx` → `Test Files 1 passed (1)`, `Tests 26 passed (26)` (25 pre-existing + 1 new). - **Full suite + baseline comparison** after the fix: `npx vitest run` → `Test Files 2 failed | 113 passed (115)`, `Tests 2 failed | 943 passed (945)` in run 1 (AclPage ×1, ConsumerPage ×2); a second full run produced `3 failed | 942 passed` (same two files, load-dependent counts). Neither file is touched by this change. To attribute them to the environment and not the fix: `git stash push -- src/pages/cluster/` (fix removed) + `vitest run src/pages/instance/__tests__/AclPage.test.tsx src/pages/instance/__tests__/ConsumerPage.test.tsx` → `Tests 54 passed (54)`; `git stash pop` and the same two files in isolation with the fix applied → `Tests 54 passed (54)`. So the failures only occur under full-suite parallel load, on files this PR does not modify — the previously documented load flakiness. - **Build**: `npx tsc --noEmit` clean; `npx eslint src/pages/cluster/index.tsx src/pages/cluster/__tests__/ClusterPage.test.tsx` clean; `npm run build` → `✓ built in 9.81s` (covers the CI web-build step, which cannot run due to the startup_failure above). - **Diff self-check**: `git show fb3cbcf5 --numstat` → `2 files changed`: `web/src/pages/cluster/index.tsx` +17/−2 (guard ref + 3 invalidation points + guarded commit), `web/src/pages/cluster/__tests__/ClusterPage.test.tsx` +70/−0 (1 new regression, 1 new type import). No unrelated changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
