unbridled-41 commented on PR #4160:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4160#issuecomment-5585844322
## Verification evidence
- **CI**: the upstream workflow does not start for any branch in this
repository at the moment. For this PR's head SHA
`733b66698f244e019bd15be097881088d1f36efa`, `gh api
/repos/apache/rocketmq-dashboard/actions/runs?head_sha=<sha>` returns exactly
one run: `CI (pull_request)` with `conclusion=startup_failure`, and
`/commits/<sha>/check-runs` reports `total_count=0` (no check runs, no
statuses). This matches recent runs of the base branch itself; nothing here can
pass or fail CI.
- **Red** (`mvn -o test -Dtest=AuthServiceDatabaseTest -DfailIfNoTests=true`
on base `0a596661` with only the tests added):
- `loginShouldNotRevealDisabledAccountsBeforeThePasswordIsVerified`:
`Expecting message to be: "Invalid username or password" but was: "User account
is disabled"` (403).
- `disabledAccountLoginsAreRateLimitedLikeWrongPasswords`: expected `429
Too many failed login attempts...` after 5 failures, but the 6th attempt again
returned `403 "User account is disabled"` — proving disabled-account attempts
never reach the limiter.
- Summary: `Tests run: 23, Failures: 2, Errors: 0` — BUILD FAILURE caused
solely by the two new tests; all 21 pre-existing tests in the class pass.
- **Module tests** after the fix: `mvn -o test
-Dtest='AuthServiceDatabaseTest,AuthServiceTest,LoginRateLimiterTest,AuthControllerTest'`
→ `Tests run: 60, Failures: 0, Errors: 0, Skipped: 0` — BUILD SUCCESS.
- **Full suite + baseline comparison** after the fix: `mvn -o test` → `Tests
run: 2134, Failures: 3, Errors: 0`. The 3 failures are
`AuthCorsIntegrationTest` (×2) and
`AliyunInstanceProviderTest.getGroupProgressShouldMapLagRowsTest` (×1) — the
documented pre-existing baseline failures, identical to a pristine base run;
zero new failures introduced (2134 = 2132 baseline + 2 new regressions).
- **Build**: `mvn -o test` compiles main and test sources before running
(BUILD SUCCESS up to the known baseline test failures); this also covers the
CI's `backend-build` compile step, which cannot run for the same
startup_failure reason.
- **Diff self-check**: `git show 733b6669 --numstat` → `2 files changed, 43
insertions(+), 3 deletions(-)`: `AuthService.java` +4/−2 (the two `if` blocks
swapped), `AuthServiceDatabaseTest.java` +40/−0 (two new regressions + no
helper changes beyond reusing the existing `user(...)` factory). No unrelated
changes; only the two files required for this fix are touched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
