tju-yxq commented on PR #3290: URL: https://github.com/apache/rocketmq-dashboard/pull/3290#issuecomment-5584542902
Thanks for the review. I checked the repository state and the review appears to have been evaluated against a different branch layout than the one this PR targets. This PR is based on the `rocketmq-studio` branch (current base: `0a596661`), where: - `web/src/api/message.ts` and the other changed paths do exist (`git cat-file -e rocketmq-studio:web/src/api/message.ts` succeeds); - there is no `frontend-new/` directory on this branch; - `propertiesTruncated` is part of the backend contract on this branch — `MessageRecordVO` (`server/src/main/java/org/apache/rocketmq/studio/instance/message/MessageRecordVO.java:45`) and `DLQMessageVO` define the field, and `RocketMQMessageProvider` (`:720`) / `RocketMQDLQProvider` (`:414`) set it when the bounded display payload is shortened. The paths and contracts described in the review (`frontend-new/src/pages/Message/message.jsx`, `frontend-new/src/components/MessageDetailViewDialog.jsx`, `src/main/java/org/apache/rocketmq/dashboard/model/MessageView.java`) match the repository's legacy `master` layout rather than `rocketmq-studio`. For reference, local validation on the `rocketmq-studio` base passed: - `npm test -- MessagePageAsyncState.test.tsx MessagePage.test.tsx QueueBrowser.test.tsx message.test.ts --run` — 45 tests passed - `npm run lint -- --quiet` — 0 errors - `npm run build` — passed Happy to make changes if there are concrete issues against the `rocketmq-studio` codebase itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
