lizhimins commented on issue #3996: URL: https://github.com/apache/rocketmq-dashboard/issues/3996#issuecomment-5581407817
Resolved by #3997, merged into `rocketmq-studio` as 4d596463. The broker table on the cluster page now carries four per-broker daily counters - messages put today, put yesterday, gotten today, gotten yesterday - derived from the runtime stats KVTable that `RocketMQClusterProvider` already fetches on every pass, so no additional admin call was introduced. Two implementation notes worth recording: - The delta parsing was consolidated rather than duplicated. `RocketMQDashboardProvider.parseMessagesToday` was removed and the single algorithm now lives in `common/util/BrokerRuntimeStats.dailyCounterDelta`, called from both the dashboard provider and the cluster provider. Yesterday's figure is computed as this-morning's cumulative counter minus yesterday-morning's, and a broker restart (counter going backwards) clamps to 0 rather than reporting a negative delta. - `ClusterRepositoryImpl.copyBroker` rebuilds brokers field by field when making its defensive copies, so the four new fields had to be added there explicitly; without that they were silently zeroed on every `findById` / `findAll`. The columns are 90px wide each, keeping the broker table's declared width total at 1620px so it still fits a 1920px viewport's content area without a default horizontal scrollbar. Because this repository squash-merges against `rocketmq-studio` rather than the default branch, GitHub does not auto-close issues referenced in a PR body; closing manually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
