Yanghanrui666 opened a new pull request, #4140: URL: https://github.com/apache/rocketmq-dashboard/pull/4140
## Summary - The `frontend-build` job in `.github/workflows/ci.yml` ran `npm ci` and `npm run build` but **never ran `npm run test`** (vitest). - This means the repo's roughly 936 frontend unit tests do not gate any PR or push to `rocketmq-studio`. - Add a `npm run test` step between install and build - a one-line addition that enforces the existing test suite on every change. Depends on #4138 (CI startup fix) being merged first, otherwise the workflow still fails at startup and no jobs run at all. Closes #4139 ## Test plan - [ ] After #4138 is merged, verify the CI workflow runs `npm run test` successfully on this PR - [ ] Verify that a breaking change to a frontend test now fails the CI check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
