btlqql opened a new pull request, #4132:
URL: https://github.com/apache/rocketmq-dashboard/pull/4132
## Problem
`SettingsService.listDataSources(search, type, page, pageSize)` used a
SpEL concatenation key. Java `null` becomes the literal text `"null"`,
so `(null, null, 1, 20)` and `("null", null, 1, 20)` shared one cache
entry.
## Fix
Remove the explicit key expression and rely on Spring default
`SimpleKeyGenerator`, which preserves each argument value and keeps
distinct tuples in distinct cache entries.
## Test plan
- Added `SettingsServiceCacheIntegrationTest` covering null versus
literal `"null"` filters.
- `mvn -q -Dtest=SettingsServiceCacheIntegrationTest test`
- `mvn -q -Dtest=SettingsServiceTest test`
Fixes #4048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
