Copilot commented on code in PR #4109:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4109#discussion_r3953884046
##########
server/src/test/java/org/apache/rocketmq/studio/ops/ai/OpenAiCompatibleLlmClientTest.java:
##########
@@ -155,6 +157,55 @@ void streamShouldParseOpenAiCompatibleSseDeltas() {
assertThat(requestBody.get().path("stream").asBoolean()).isTrue();
}
+ @Test
+ void streamShouldIgnoreNonContentDeltasAndStopAtDoneTest() {
Review Comment:
New test method name ends with `Test`, but other test methods in this class
do not. Consider dropping the suffix for consistency and cleaner display in
test reports.
This issue also appears on line 189 of the same file.
##########
server/src/test/java/org/apache/rocketmq/studio/ops/ai/OpenAiCompatibleLlmGatewayTest.java:
##########
@@ -266,6 +266,42 @@ void successfulAndFailedStreamsEmitOneTerminalSequence()
throws Exception {
}
}
+ @Test
+ void httpEnhanceShouldPreserveWhitespaceOnlyChunksTest() throws Exception {
Review Comment:
This newly added test method name ends with `Test`, while most tests in this
class omit that suffix. Consider renaming to keep naming consistent within the
suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
