yyqdbngt commented on PR #4073: URL: https://github.com/apache/rocketmq-dashboard/pull/4073#issuecomment-5572015741
Thanks for the review — addressed all five points in the latest push: 1. Removed `PR_BODY.md` from the commit; it now contains only the test file. 2. Removed the `attachThresholdUnit` case that duplicated `alerts.test.ts`. 3. Moved the `thresholdUnits` map assertions into their own `it` block and covered all five known metrics. 4. Renamed the duration test to `maps known Chinese duration labels and passes unknown ones through unchanged`. 5. Added direct assertions for all five legacy metric mappings (`消费堆积量`, `TPS 异常`, `Broker 离线`, `Proxy 连接数`), plus a separate unknown-metric pass-through case. `vitest run src/pages/ops/__tests__/alertRulePayload.test.ts` → 4/4 passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
