unbridled-41 commented on PR #4004:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4004#issuecomment-5560945596
## Verification evidence
**CI**: upstream CI cannot run here. Head commit
`7c9b46734b7b8907e9cbf010d3be7e816a27da6b`: `commits/{sha}/check-runs` →
`total_count: 0`, `commits/{sha}/status` → 0 statuses (no workflow started for
this head); recent `rocketmq-studio` base-branch runs are `startup_failure`,
pre-existing and unrelated.
**Red light (before the fix)** — `npx vitest run
src/pages/ops/__tests__/AlertsPage.test.tsx`:
```
× resets page, search and status filters when the domain switches
expect(listAlertRulesPage).toHaveBeenLastCalledWith('BUSINESS', {page: 1,
...})
(failed: after switching to domain="BUSINESS" the fetch still carried
the retained page: 2 / search: 'disk')
Tests 1 failed | 22 passed (23)
```
**Green light / module tests (after the fix)**: `Tests 23 passed (23)` (22
pre-existing + 1 new).
**Full suite + baseline**: `npx vitest run --testTimeout=60000` → first full
run `3 failed | 920 passed (923)` with the 3 failures in untouched files
(NotificationDeliveriesPage pointer-events etc.), consistent with this suite's
documented load sensitivity; an immediate clean full run: `Test Files 115
passed (115), Tests 923 passed (923)` — zero failures.
**Build**: `npx tsc --noEmit` clean; `npx eslint src/pages/ops/alerts.tsx
src/pages/ops/__tests__/AlertsPage.test.tsx` → 0 errors (5 pre-existing
warnings, verified identical on the pristine baseline); `npm run build`
succeeds.
**Diff self-check**: 2 files, +59/−0 — `alerts.tsx` (+11: render-time
domain-change reset) and `AlertsPage.test.tsx` (+48: 1 regression test). No
unrelated changes. (An initial effect-based reset was rejected by this repo's
`react-hooks/set-state-in-effect` lint rule; the committed pattern is React's
documented "adjust state when a prop changes" render-time reset and lints
clean.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
