unbridled-41 commented on PR #4005:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4005#issuecomment-5560945694
## Verification evidence
**CI**: upstream CI cannot run here. Head commit
`89895053590e3cff5fe54193f9fc5f4725120ced`: `commits/{sha}/check-runs` →
`total_count: 0`, `commits/{sha}/status` → 0 statuses (no workflow started for
this head); recent `rocketmq-studio` base-branch runs are `startup_failure`,
pre-existing and unrelated.
**Red light (before the fix)** — `npx vitest run
src/pages/instance/__tests__/MessagePage.test.tsx`:
```
× paginates against the committed query instead of live form inputs
AssertionError: expected last "vi.fn()" call to have been called with [
ObjectContaining{…} ]
(page 2 was fetched with the edited topic payment-callback instead of
the committed topic order-create)
Tests 1 failed | 9 passed (10)
```
**Green light / module tests (after the fix)**: MessagePage.test.tsx +
MessagePageAsyncState.test.tsx → `Tests 28 passed (28)` (27 pre-existing + 1
new).
**Full suite + baseline**: `npx vitest run --testTimeout=60000` → `Test
Files 115 passed (115), Tests 923 passed (923)` — zero failures.
**Build**: `npx tsc --noEmit` clean; `npx eslint
src/pages/instance/message.tsx
src/pages/instance/__tests__/MessagePage.test.tsx` → no problems; `npm run
build` succeeds (`✓ built in 10.06s`).
**Diff self-check**: 2 files, +61/−3 — `message.tsx` (+24/−3:
committedQueryRef snapshot in executeQuery and replayHistoryRecord, pagination
uses the snapshot) and `MessagePage.test.tsx` (+40/−1... +39/−1 net: 1
regression test + fireEvent import). No unrelated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
