unbridled-41 commented on PR #3991:
URL:
https://github.com/apache/rocketmq-dashboard/pull/3991#issuecomment-5557755125
## Verification evidence
- **CI**: head `f2bd8631e43fb33ff584e8523fbbf78b7abfe296` has 0 check runs
and 0 statuses (combined state `pending`, no workflow run for this commit —
verified via `commits/{sha}/check-runs`, `/status`, and
`actions/runs?head_sha`). Upstream CI currently fails to start for all
branches, so results below come from local execution.
- **Red (before the fix)**: with the implementation stashed and only tests
applied — server `mvn test-compile`: 9 compilation errors
(`updateConsumerGroupSettings ... cannot be applied to given types` ×5 in
`RocketMQAdminClientImplTest`/`ConsumerGroupControllerTest`, `cannot find
symbol: method consumeEnable(boolean)` ×2,
`consumeMessageOrderly(boolean)`/`consumeBroadcastEnable(boolean)`); web
`vitest run -t "consumption switches"`: `TestingLibraryElementError: Unable to
find role="switch" and name "启用消费"`.
- **Module tests**: `mvn -ntp test
-Dtest='RocketMQAdminClientImplTest,ConsumerGroupControllerTest,MetadataServiceTest'`
→ Tests run: 100, Failures: 0, Errors: 0. Web: `npx vitest run
src/pages/instance/__tests__/ConsumerPage.test.tsx` → 30 passed (30).
- **Full suites + baseline**: backend `mvn -ntp clean test` → 2038 tests, 4
failures — byte-identical to the pristine baseline of 36126024
(AuthCorsIntegrationTest ×2,
AliyunInstanceProviderTest.getGroupProgressShouldMapLagRowsTest, load-fragile
OpenAiCompatibleLlmGatewayTest, 9/9 in isolation); 2038 = 2035 baseline + 3 new
tests, zero new failures. Web `npx vitest run` → 923 tests, 2 failures
(ClientsPage, ConsumerPage health diagnostics) — both in untouched files, both
pass in isolation (the two files together 48/48), matching the documented load
fragility of the full web suite in this sandbox.
- **Build**: `npm run build` succeeds (vite build ✓); `npx tsc -b` clean;
`eslint` clean on the changed web files. Backend compiled as part of `mvn test`.
- **Diff self-check**: 11 files, +219/−16 — 6 server main files
(VO/DTO/interface/impl/service/controller), 2 server test files, 3 web files
(type + settings tab + test). No unrelated changes, no formatting-only churn,
no generated/vendor edits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
