yyqdbngt opened a new pull request, #3971:
URL: https://github.com/apache/rocketmq-dashboard/pull/3971

   ### Motivation
   
   `GeneralSettingsUpdateDTO` had no unit coverage for its required fields, 
timeout bounds, secret redaction, or VO conversion. This PR adds first coverage.
   
   ### Changes
   
   - The required fields are enforced (validated by property).
   - sessionTimeout is bounded to 5-1440.
   - toString never exposes the api key or dingtalk signing secret.
   - toSettings round-trips the payload incl. clear flags.
   
   ### Verification
   
   - `mvn -B test -Dtest=GeneralSettingsUpdateDTOTest`: 5/5 passed, BUILD 
SUCCESS


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to