yyqdbngt opened a new pull request, #3873:
URL: https://github.com/apache/rocketmq-dashboard/pull/3873

   ### Motivation
   
   The ACL service unit tests covered copy semantics and the plain-access 
lifecycle, but left deletion, credential lookup, update failures, and the 
rule/user filter surface untested. This PR grows the suite from 10 to 17 cases.
   
   ### Changes
   
   - `deleteAclRule` / `deleteAclUser`: remove the created entity from mock 
state, and resolve silently for an unknown id.
   - `getAclUserCredentials`: returns a defensive copy of the stored account 
(cluster mutation does not leak) and rejects unknown users with `ACL user not 
found`.
   - `updateAclRule` / `updateAclUser` throw a not-found error when the id is 
absent from mock state.
   - `listAclRules` filter surface: scope, decision, ACL version, resource 
substring, case-insensitive principal, plus pagination with `page`/`pageSize` 
and stable `total`.
   - `listAclUsers` case-insensitive keyword narrowing.
   
   ### Verification
   
   - `vitest run src/services/aclService.test.ts`: 17/17 passed
   - `tsc --noEmit`: clean
   - `eslint src/services/aclService.test.ts`: clean


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to