yyqdbngt opened a new pull request, #3857: URL: https://github.com/apache/rocketmq-dashboard/pull/3857
### Motivation The existing `NativeAlertRuleTestServiceTest` covers group-scoped evaluation, metric filtering, key normalisation and per-collector failure isolation. The unknown-instance rejection and the unsupported-collector skip were untested. ### Changes - `testShouldRejectUnknownInstance`: an unresolvable instance id raises a 404 `Instance not found` before any collection. - `testShouldSkipCollectorsThatDoNotSupportTheInstance`: collectors that do not support the instance are never invoked and the result stays empty. ### Verification ``` mvn -B test -Dtest=NativeAlertRuleTestServiceTest [INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0 [INFO] BUILD SUCCESS ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
