yyqdbngt opened a new pull request, #3840:
URL: https://github.com/apache/rocketmq-dashboard/pull/3840

   ### Motivation
   
   The existing `CloudRocketMqClusterMetricsCollectorTest` covers the running 
and stopped states only. The `supports` gate, the case-insensitive running 
match, the null detail and the catalog-failure degradation were untested.
   
   ### Changes
   
   - `collectSkipsUnsupportedInstances`: non-cloud vendors and instances 
without a credential yield no samples, and the collector advertises its metric 
key.
   - `runningStatusIsMatchedCaseInsensitively`: a lower-case `running` status 
still reports an available sample.
   - `nullDetailMapsToUnavailableWithoutStatusLabel`: a null provider detail 
degrades to unavailable with only the instance label.
   - `catalogFailureMapsToUnavailableWithoutStatusLabel`: a provider exception 
degrades to unavailable without a status label.
   
   ### Verification
   
   ```
   mvn -B test -Dtest=CloudRocketMqClusterMetricsCollectorTest
   [INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0
   [INFO] BUILD SUCCESS
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to