yyqdbngt opened a new pull request, #3821:
URL: https://github.com/apache/rocketmq-dashboard/pull/3821

   ### Motivation
   
   The existing `MiniBar` tests cover zero values and the minimum visible 
height. The empty-series placeholder, proportional scaling within the chart 
height and the aria-label contract were untested.
   
   ### Changes
   
   - `renders a placeholder when the data series is empty`: an empty series 
shows the `—` placeholder without an image role.
   - `scales bar heights within the chart height`: heights are proportional to 
the series maximum (`1/5` and `5/5` of a 100px chart).
   - `exposes the label through the image role`: the custom label lands on the 
`img` role's aria-label.
   
   ### Verification
   
   ```
   ./node_modules/.bin/vitest run src/components/__tests__/MiniBar.test.tsx   # 
5 passed
   ./node_modules/.bin/tsc --noEmit                                          # 
clean
   ./node_modules/.bin/eslint src/components/__tests__/MiniBar.test.tsx      # 
clean
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to