yyqdbngt opened a new pull request, #3815:
URL: https://github.com/apache/rocketmq-dashboard/pull/3815

   ### Motivation
   
   The existing `AlertRuleRequestDTOTest` covers channel validation, composite 
durations, channel normalisation and metric trimming, but the `toAlertRuleVO` 
defaults for absent optional fields and the full field-copy contract were 
untested.
   
   ### Changes
   
   - `toAlertRuleVOShouldApplyDefaultsForNullOptionalFields`: null 
aggregation/window/consecutive-samples/reminder-interval fall back to 
`LAST`/0/1/`30m`, and null metric/channels stay null.
   - `toAlertRuleVOShouldCopyExplicitRuntimeFields`: every configured field — 
operator, threshold, duration, aggregation, severity, scope selectors, 
intervals and the notification template — lands verbatim on the VO.
   
   ### Verification
   
   ```
   mvn -B test -Dtest=AlertRuleRequestDTOTest
   [INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0
   [INFO] BUILD SUCCESS
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to