yyqdbngt opened a new pull request, #3769:
URL: https://github.com/apache/rocketmq-dashboard/pull/3769

   ### Motivation
   
   The existing `ApacheAclReadServiceTest` covers the partial-failure 
aggregation and null-row tolerance, but leaves the iteration guards of the 
broker-table walk unverified: duplicate master addresses, broker entries with 
no master, the root-cause unwrapping for failure messages, and a missing broker 
table.
   
   ### Changes
   
   - `skipsDuplicateMasterAddressAcrossBrokerEntries`: two broker entries 
sharing one master address trigger a single `listAcl` call and a single policy 
key.
   - `skipsBrokerEntriesWithoutMasterAddress`: entries with no address table or 
only slave addresses never reach `listAcl` and yield an empty, non-partial 
result.
   - `usesDeepestRootCauseAsFailureMessage`: a wrapped failure records the 
deepest cause message instead of the outer one.
   - `treatsMissingBrokerTableAsEmptyResult`: a `ClusterInfo` with no broker 
table short-circuits to an empty result without any `listAcl` invocation.
   
   ### Verification
   
   ```
   mvn -B test -Dtest=ApacheAclReadServiceTest
   [INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0
   [INFO] BUILD SUCCESS
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to