yyqdbngt opened a new pull request, #3765:
URL: https://github.com/apache/rocketmq-dashboard/pull/3765

   ### Motivation
   
   `OperationAuditServiceTest` currently locks in the operator resolution and 
the non-propagating sink failure, but never asserts that every audit field 
actually lands on the persisted entity, nor that a failure reason is carried 
through while optional fields stay null.
   
   ### Changes
   
   - `recordShouldPersistEveryProvidedField`: after a successful insert, the 
captured `RmqOperationAudit` carries the exact operation, resource type/name, 
cluster id, detail and result, plus the authenticated operator; `gmtCreate` is 
set and `gmtModified` matches it.
   - `recordShouldCarryFailureReasonAndTolerateNullOptionalFields`: a failed 
operation with a broker-side reason records `result=FAILED` and the reason 
while `resourceName`/`clusterId` remain null and the operator falls back to 
`SYSTEM_ACTOR`.
   
   ### Verification
   
   ```
   mvn -B test -Dtest=OperationAuditServiceTest
   [INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0
   [INFO] BUILD SUCCESS
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to