yyqdbngt opened a new pull request, #3326:
URL: https://github.com/apache/rocketmq-dashboard/pull/3326

   ## Summary
   
   Extends the existing `CloudRocketMqClusterMetricsCollectorTest` (2 to 6 
tests) to pin down the cloud cluster collector contract.
   
   Added cases:
   - `supports` requires the full cloud coordinates (name, credential id, 
region id, cloud instance id, cloud vendor) and rejects incomplete/Apache/null 
instances;
   - `metricKeys` exposes only `cloud.instance.availability`;
   - a failing catalog query degrades to a single `UNAVAILABLE` sample carrying 
only the base labels (no `cloudStatus`);
   - a missing detail (null status) is likewise `UNAVAILABLE` without a 
`cloudStatus` label.
   
   ## Why
   
   The collector feeds native cloud availability alerting; only the 
RUNNING/STOPPED happy paths were covered before.
   
   ## Testing
   
   `mvn -B test -Dtest=CloudRocketMqClusterMetricsCollectorTest` — 6/6 pass; 
checkstyle (validate) clean.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to