unbridled-41 commented on PR #11038:
URL: https://github.com/apache/rocketmq/pull/11038#issuecomment-5551614593
Evidence chain (audit 2026-09-05):
**Before the fix** — base ff8f6f74c + regression test only (production
change stashed):
```
mvn -pl broker test
-Dtest=ScheduleMessageServiceTest#testMessageTimeUpPropertiesStringMatchesProperties
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0
java.lang.AssertionError
at
...ScheduleMessageServiceTest.testMessageTimeUpPropertiesStringMatchesProperties(ScheduleMessageServiceTest.java:298)
```
The first failing assertion is
`assertFalse(delivered.getPropertiesString().contains(MessageConst.PROPERTY_DELAY_TIME_LEVEL))`
— pre-fix the persisted wire string still carries
`DELAY_TIME_LEVEL`/`TIMER_DELIVER_MS` and differs from re-encoding the cleared
property map.
**After the fix** — branch tip f7752f5a3, re-measured 2026-09-05:
```
mvn -pl broker test -Dtest=ScheduleMessageServiceTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0
```
Precedent anchor: the identical defect class in
`TimerMessageStore#convertMessage` was fixed upstream in e533b663f (ISSUE
#10972, encode after `clearProperty`, encode `msgInner.getProperties()`); the
schedule path was not covered there, and the 2022-era PR #4190 that attempted
it was closed unmerged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
