zjncs opened a new pull request, #11018:
URL: https://github.com/apache/rocketmq/pull/11018

   ## Which Issue(s) This PR Fixes
   
   Fixes #11010
   
   ## Brief Description
   
   When Netty `writeAndFlush` fails asynchronously, `requestFail` previously 
discarded `ChannelFuture.cause()`. This caused callbacks and 
`RemotingSendRequestException` to lose the underlying failure reason.
   
   This change passes the cause into `ResponseFuture.setCause`; channel-close 
failures continue to pass `null` because no asynchronous write cause is 
available there.
   
   ## How Did You Test This Change?
   
   - Base SHA: `$(git rev-parse develop)`.
   - Confirmed current `invoke0` called `requestFail(opaque)` despite 
`f.cause()` being available.
   - `git diff --check` passed.
   - Maven is unavailable in this environment, so the required test suite was 
not run; CI should validate.
   
   ## Risk
   
   Low; only enriches failure exceptions with the cause already supplied by 
Netty.
   
   AI-assisted contribution; implementation and verification performed against 
current `develop`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to