yyqdbngt opened a new pull request, #3274:
URL: https://github.com/apache/rocketmq-dashboard/pull/3274

   ## Summary
   
   Extends the existing `LlmConfigVOTest` (1 to 4 tests) to pin down the LLM 
configuration readiness and secret-handling contract.
   
   Added cases:
   - `isApiKeyConfigured` reflects only textual api keys;
   - the full `isReady` matrix: disabled or model-less configs are never ready; 
CLI engines need only enabled + model (credentials come from the subprocess 
environment); HTTP + `ollama` needs an api base but no key; HTTP + other 
providers need both an api base and a key;
   - Jackson serialization never emits the `apiKey` (write-only) while exposing 
the derived `apiKeyConfigured` flag, and a write-only field still accepts input 
on deserialization.
   
   ## Why
   
   The VO drives the settings page state and gateway readiness checks; only 
engine normalization was covered before.
   
   ## Testing
   
   `mvn -B test -Dtest=LlmConfigVOTest` — 4/4 pass; checkstyle (validate) clean.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to