yyqdbngt opened a new pull request, #3234: URL: https://github.com/apache/rocketmq-dashboard/pull/3234
## Summary The ACL page renders risk diagnostics issues (title/description/recommendation triples) built by a pure utility that returned hard-coded zh. Localized in utils/aclRiskDiagnostics.ts: - `analyzeAclRisk` accepts `lang` (default `zh`); status text resolves through a new English status map in en. - All collectors (`addDefaultPermissionIssues`, `addWildcardPermissionIssues`, `addInvalidPermissionEntryIssues`, `addAccountIssues`) accept `lang`; every issue triple is bilingual (broad / non-DENY default Topic & Group permissions, broad Topic/Group wildcards, unrecognized permission entries, missing/duplicate Access Keys, broad account whitelists, admin accounts on broad networks). - Cluster-level issues (ACL disabled, legacy ACL version, no Plain Access accounts, broad global whitelist, too many admins) are bilingual; `buildRecommendations` bilingual including its default fallback. - pages/instance/acl.tsx passes the current language. - No behavior change in zh. ## Why The ACL risk diagnostics are the security surface of the ACL page; issue text and advice must follow the active language. ## Testing - `tsc --noEmit` passes - `eslint` clean on the changed files - `vitest run` aclRiskDiagnostics + AclPage - 25/25 tests pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
