unbridled-41 commented on PR #10994:
URL: https://github.com/apache/rocketmq/pull/10994#issuecomment-5547356810
Evidence chain re-verified on 2026-09-05 (JDK 21, Maven 3.8.7), anchored to
commits:
- **After fix** — branch tip 1db39b7b7:
`mvn -pl broker test -Dtest=PopLongPollingServiceTest` → `Tests run: 12,
Failures: 0, Errors: 0, Skipped: 0` (corrects the 13/13 figure mentioned
previously — 12 is the actual class size on this branch).
- **Before fix** — base commit e348efa66 with the same regression test file:
`mvn -pl broker test
-Dtest=PopLongPollingServiceTest#testNotifyMessageArrivingFromRetryWithoutProperties`
→
`Tests run: 1, Errors: 1` — `java.lang.NullPointerException: Cannot invoke
"java.util.Map.get(Object)" because "properties" is null`
(PopLongPollingServiceTest.java:126), i.e. the exact unguarded dereference
fixed by the early return.
- **CI**: all 10 checks green on this PR (maven-compile linux/macos/windows,
bazel, CodeQL, license, misspell; `calculate-coverage` fails on the unmodified
develop baseline as well and is unrelated).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
