RockteMQ-AI commented on issue #3165:
URL:
https://github.com/apache/rocketmq-dashboard/issues/3165#issuecomment-5545270425
**Issue Evaluation**
Category: `enhancement` | Status: **Evaluated**
**Feasibility:** Feasible
**Scope:** `AlertSilenceController` (backend — add update endpoint),
maintenance window form component (frontend — add edit action with pre-fill)
**Compatibility:** No breaking changes — additive API endpoint + UI
enhancement.
This is a reasonable feature request. The current create-only workflow
forces delete-and-recreate for any adjustment, which risks alert-suppression
gaps and loses record provenance.
Suggested implementation approach:
1. **Backend:** Add `PUT /api/silence/{id}` (or `PATCH`) to
`AlertSilenceController`, reusing the same validation logic from the create
path (end > start, valid recurrence timezone, bounded duration, required
recurrence end, valid ISO weekdays, bounded labels/reason).
2. **Audit:** Log the update as `alert-silence-update` in the operation
audit log, preserving the original creator.
3. **Frontend:** Add an "Edit" action to the maintenance window list that
pre-fills the creation form with existing values. On submit, call the update
endpoint instead of create.
4. **Record identity:** The update must preserve the original record ID and
creator — no new record created.
The scope is well-contained and the change is backward-compatible.
---
*Automated evaluation by @RockteMQ-AI*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
